modules_k/dialog: Revert "Prevent 'unable to find dialog' WARN
authorTimo Reimann <timo.reimann@1und1.de>
Thu, 5 Aug 2010 15:23:34 +0000 (17:23 +0200)
committerTimo Reimann <timo.reimann@1und1.de>
Thu, 5 Aug 2010 15:23:34 +0000 (17:23 +0200)
commit0723496c037d8e22210861d6a0e9041351097f63
tree6a8c15115acdc1082741dfc2bc382dd142090d49
parent3fe8eea70560205d8ffe6b82902ea717d0e33279
modules_k/dialog: Revert "Prevent 'unable to find dialog' WARN
messages caused by accessing a dialog in the "deleted" state".

The approach chosen was incomplete as it requires extending checks
of return values for all calls to get_dlg() and lookup_dlg()
against POINTER_CLOSED_MARKER. Otherwise, it may lead to server
crashes when code mistakes POINTER_CLOSED_MARKER for an existing
dialog. However, having to check against two return values
requires a lot of logic changes.

Therefore, a better approach will be taken in a follow-up commit.

This reverts commit 9b7f25d7196e41cbcc77c1d6e316cb1a8664ed81.
modules_k/dialog/dlg_cb.c
modules_k/dialog/dlg_handlers.c
modules_k/dialog/dlg_hash.c
modules_k/dialog/dlg_hash.h