pdb: covert byte-by-byte from buffer to short-int to avoid unalignment compile warning
authorDaniel-Constantin Mierla <miconda@gmail.com>
Mon, 27 Apr 2020 08:47:48 +0000 (10:47 +0200)
committerDaniel-Constantin Mierla <miconda@gmail.com>
Mon, 27 Apr 2020 08:47:48 +0000 (10:47 +0200)
- GH #2298

src/modules/pdb/pdb.c

index b72ecf7..1ab15af 100644 (file)
@@ -189,6 +189,8 @@ static int pdb_msg_format_send(struct pdb_msg *msg,
 }
 
 
+/* two chars to short-int without caring of memory alignment in char buffer */
+#define PDB_BUFTOSHORT(_b, _n) (((short int)_b[_n]) << 8) | (0x00ff & _b[_n+1])
 
 /*!
  * \return 1 if query for the number succeded and the avp with the corresponding carrier id was set,
@@ -199,7 +201,7 @@ static int pdb_query(struct sip_msg *_msg, struct multiparam_t *_number, struct
     struct pdb_msg msg;
        struct timeval tstart, tnow;
        struct server_item_t *server;
-       short int carrierid, *_id;
+       short int carrierid, _id;
        short int _idv;
     char buf[sizeof(struct pdb_msg)];
        size_t reqlen;
@@ -345,8 +347,8 @@ static int pdb_query(struct sip_msg *_msg, struct multiparam_t *_number, struct
                                 case PDB_CODE_OK:
                                     msg.bdy.payload[sizeof(struct pdb_bdy) - 1] = '\0';
                                     if (strcmp(msg.bdy.payload, number.s) == 0) {
-                                        _id = (short int *)&(msg.bdy.payload[reqlen]); /* make gcc happy */
-                                        carrierid=ntohs(*_id); /* convert to host byte order */
+                                        _id = PDB_BUFTOSHORT(msg.bdy.payload, reqlen); /* make gcc happy */
+                                        carrierid=ntohs(_id); /* convert to host byte order */
                                         goto found;
                                     }
                                     break;
@@ -368,8 +370,8 @@ static int pdb_query(struct sip_msg *_msg, struct multiparam_t *_number, struct
                         default:
                             buf[sizeof(struct pdb_msg) - 1] = '\0';
                             if (strncmp(buf, number.s, number.len) == 0) {
-                                _id = (short int *)&(buf[reqlen]);
-                                carrierid=ntohs(*_id); /* convert to host byte order */
+                                _id = PDB_BUFTOSHORT(buf, reqlen); /* make gcc happy */
+                                carrierid=ntohs(_id); /* convert to host byte order */
                                 goto found;
                             }
                             break;